Open
Conversation
I also got rid of the non parsable version as it is kinda useless and doesn't lend to this new code unless I add additional logic to handle the different regions considered.
Previously chromosome was being converted to int, which doesn't work when the chromosome starts with "chr" (standard)
Due to parallelism, the order of inputs isn't necessarily going to be the order of results. So a bunch of numbers doesn't really give you any information. Instead, the region is printed alongside the metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request will allow for the user to input multiple regions in one run of the script and the script now has built in multiprocessing to assist with this. The wrapper script doesn't lend well to this change, but I don't care about that as it is mainly there as an example of what you can do. With a different wrapper script, one could find all peak regions in dataset A and then feed these positions into the python script (parallelising further across multiple cores for each chromosome for example).
Type of change
Checklist: